fix: align MAC address api with Arduino reference#89
Merged
fpistm merged 3 commits intostm32duino:mainfrom Sep 11, 2024
Merged
Conversation
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Anyway the MAC address get by the application is always 0 while the real address is correct. Will be fixed by latter commit. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
5a50a4e to
ac94829
Compare
References: https://www.arduino.cc/reference/en/libraries/ethernet/ethernet.macaddress/ https://www.arduino.cc/reference/en/libraries/ethernet/ethernet.setmacaddress/ Pay attention that setMACAddress have to be called before Begin(). Else new MAC will be ignored. Fixes stm32duino#81 Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References:
https://www.arduino.cc/reference/en/libraries/ethernet/ethernet.macaddress/ https://www.arduino.cc/reference/en/libraries/ethernet/ethernet.setmacaddress/
Important
Pay attention that
setMACAddress()have to be called beforeBegin().Else new MAC will be ignored.
This PR also fixes with the default MAC address usage. It is used only if one or more
MAC_ADDRxdefined.The MAC address is also correct at all level.
Fixes #81
Test sketch